chart/example-idp enable self signed certs
nazarkulyk opened this issue · 2 comments
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- This issue affects my Ory Cloud project.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Describe your problem
Currently helm chart for don't allow pass nodejs env settings to ignore TLS errors if self signed certs was used on hydra.
Describe your ideal solution
Please extend (https://github.com/ory/k8s/tree/master/helm/charts/example-idp/templates/deployment.yaml) with extra env setup:
env:
- name: NODE_TLS_REJECT_UNAUTHORIZED
value: {{ .Values.nodeTlsRejectUnauthorized }}
Workarounds or alternatives
Currently there is no workarround except fork project and create own template. Which is fine, but for 5 min quick start with minikube and local env i think its cool to be able to set this env for nodejs.
Version
1.4.6
Additional Context
Chart version: 0.23.3
Hi there, good point. The chart has been left mostly untouched since a long time. I will add the standard extraEnv support to it so you can pass any arbitrary envs
Actually i updated all versions of images by setting image.tag, also used mocktls to enable https termination and it just worked fine, but i also think that extraEnv is good idea... @Demonsthere
Thanks