ory/k8s

Keto chart uses `strategy` from wrong location in values.yaml

Closed this issue · 0 comments

Preflight checklist

Ory Network Project

No response

Describe the bug

The Keto Helm chart has the deployment strategy in the values.yaml in this location:

deployment:
## -- Specify pod deployment strategy
strategy:
type: RollingUpdate
rollingUpdate:
maxSurge: "25%"
maxUnavailable: "25%"

But the actual Deployment spec references just .Values.strategy:

strategy:
{{- toYaml .Values.strategy | nindent 4 }}

This results in the Keto Deployment being created with strategy: null, which then defaults to RollingUpdate anyway so it's not obvious it's happening.

Reproducing the bug

Try to override the Keto deployment strategy by modifying the default value in the values.yaml and see it has no effect. You have to put the strategy key at the top level to make it work.

Relevant log output

No response

Relevant configuration

No response

Version

0.44.0

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response