Keto chart uses `strategy` from wrong location in values.yaml
Closed this issue · 0 comments
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Ory Network Project
No response
Describe the bug
The Keto Helm chart has the deployment strategy in the values.yaml
in this location:
k8s/helm/charts/keto/values.yaml
Lines 266 to 272 in ae7785e
But the actual Deployment spec references just .Values.strategy
:
k8s/helm/charts/keto/templates/deployment.yaml
Lines 42 to 43 in ae7785e
This results in the Keto Deployment being created with strategy: null
, which then defaults to RollingUpdate
anyway so it's not obvious it's happening.
Reproducing the bug
Try to override the Keto deployment strategy by modifying the default value in the values.yaml and see it has no effect. You have to put the strategy
key at the top level to make it work.
Relevant log output
No response
Relevant configuration
No response
Version
0.44.0
On which operating system are you observing this issue?
None
In which environment are you deploying?
None
Additional Context
No response