ory/x

Missing configuration for Jaeger

Closed this issue · 1 comments

Preflight checklist

Describe the bug

It's missing some configuration for jaegerremote and traces are not being sent.

		jaegerRemoteSampler := jaegerremote.New(
			"jaegerremote",
			jaegerremote.WithSamplingServerURL(samplingServerURL),
		)

Reproducing the bug

  1. Use a docker-compose to run jaeger https://github.com/jaegertracing/jaeger/blob/main/examples/hotrod/docker-compose.yml
  2. Clone repo https://github.com/ory/oathkeeper and use master branch
  3. Add tracing with sampling to your configuration:
tracing:
  service_name: ory-oathkeeper
  provider: jaeger
  providers:
    jaeger:
      sampling:
        type: const
        server_url: http://127.0.0.1:5778/sampling
      local_agent_address: 127.0.0.1:6831
  1. Execute some curls to oathkeeper as proxy
  2. Check traces on jaeger

Relevant log output

No response

Relevant configuration

No response

Version

master

On which operating system are you observing this issue?

None

In which environment are you deploying?

None

Additional Context

No response

Thank you for the PR :)