Missing configuration for Jaeger
Closed this issue · 1 comments
daviddelucca commented
Preflight checklist
- I could not find a solution in the existing issues, docs, nor discussions.
- I agree to follow this project's Code of Conduct.
- I have read and am following this repository's Contribution Guidelines.
- This issue affects my Ory Network project.
- I have joined the Ory Community Slack.
- I am signed up to the Ory Security Patch Newsletter.
Describe the bug
It's missing some configuration for jaegerremote and traces are not being sent.
jaegerRemoteSampler := jaegerremote.New(
"jaegerremote",
jaegerremote.WithSamplingServerURL(samplingServerURL),
)
Reproducing the bug
- Use a docker-compose to run jaeger https://github.com/jaegertracing/jaeger/blob/main/examples/hotrod/docker-compose.yml
- Clone repo https://github.com/ory/oathkeeper and use master branch
- Add tracing with sampling to your configuration:
tracing:
service_name: ory-oathkeeper
provider: jaeger
providers:
jaeger:
sampling:
type: const
server_url: http://127.0.0.1:5778/sampling
local_agent_address: 127.0.0.1:6831
- Execute some curls to oathkeeper as proxy
- Check traces on jaeger
Relevant log output
No response
Relevant configuration
No response
Version
master
On which operating system are you observing this issue?
None
In which environment are you deploying?
None
Additional Context
No response
aeneasr commented
Thank you for the PR :)