oshaughn/research-projects-RIT

Python3 syntax issues in 0.0.15.0 scripts

duncanmmacleod opened this issue · 3 comments

The conda build on 0.0.15.0 complains loudly about the following python3 syntax issues:

Installing collected packages: RIFT
  Created temporary directory: /private/tmp/pip-unpacked-wheel-pdkz_2b7
  *** Error compiling '/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_CleanILE.py'...
  Sorry: TabError: inconsistent use of tabs and spaces in indentation (util_CleanILE.py, line 55)
  *** Error compiling '/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_GenerateMaxlnLWaveform_NRFromIndex.py'...
  Sorry: TabError: inconsistent use of tabs and spaces in indentation (util_GenerateMaxlnLWaveform_NRFromIndex.py, line 178)
  *** Error compiling '/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_NRBestOfIndex.py'...
  Sorry: TabError: inconsistent use of tabs and spaces in indentation (util_NRBestOfIndex.py, line 133)
  *** Error compiling '/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_NRExtrudeOverlapGrid.py'...
  Sorry: TabError: inconsistent use of tabs and spaces in indentation (util_NRExtrudeOverlapGrid.py, line 366)
  *** Error compiling '/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_NRWriteFrame.py'...
    File "/private/tmp/pip-unpacked-wheel-pdkz_2b7/RIFT-0.0.15.0.data/scripts/util_NRWriteFrame.py", line 57
      print "Importing ", group, param
                       ^
  SyntaxError: Missing parentheses in call to 'print'. Did you mean print("Importing ", group, param)?

Fixing now, sorry (the NR scripts explicitly aren't tested because NR simulations aren't present - and there are a few simple CI-level issues like this)

I can release a new version to fix these issues now (0.0.15.1rc2 -> 0.0.15.1). Let me know if that's easier. (Right now NR is done with the 0.0.14.7 tree)

I makes no difference to me how this is done. It doesn't fail the conda build, just loud warnings. Thanks.