osmlab/osmlint

[Validator] Detect private source on objects

Rub21 opened this issue · 7 comments

Rub21 commented
[Validator] Detect private source on objects
Rub21 commented

great job here #196 @karitotp .

@maning @planemad @geohacker what do you think to upload this detection to to-fix?
example: https://gist.github.com/anonymous/082afb47aa454348b75c1bb1dd392878

@karitotp @Rub21 Can you explain more what do we mean by private source? The sample shows one with a tag source=google but I'm not sure about the others.

@maning reviewing some wikis such as WikiProject Malaysia, I found these private sources to add objects to OSM.
cc. @Rub21

I see. This is great! Made some minor comments on the code. Over to @geohacker .

Rub21 commented

I've fixed the minor issues here, I think we are ready to merge..?

@Rub21 - this is still looking for an exact match. What if the source tag in the feature was something like google earth or Google earth? Can we make them case insensitive? May be use a regular expression so we can catch a wide range of combinations?

Rub21 commented

done here #196!!