osmosis-labs/cosmos-sdk

non-deterministic data race in coin validation

p0mvn opened this issue · 1 comments

p0mvn commented

Background

A job failed in an unrelated PR:
https://github.com/osmosis-labs/cosmos-sdk/runs/6014355771?check_suite_focus=true

Noticed unsynchronized shared resources reDnm and reDecCoin:
https://github.com/osmosis-labs/cosmos-sdk/blob/ed9910d57ff97a54ada98d69b2bd5ad8f22cbc7c/types/coin.go#L709-L722

Acceptance Criteria

  • data race is fixed
  • resources are synhronized
  • unit tests added
p0mvn commented

I haven't seen this issue pop-up so going to close this