ossc-db/pg_bulkload

Extension version pg_bulkload mistake

cesarjorgemartinez opened this issue · 6 comments

cesarjorgemartinez commented

I compile the pg_bulkload using (version 3.1.20 https://github.com/ossc-db/pg_bulkload/releases/download/VERSION3_1_20/pg_bulkload-3.1.20.tar.gz):
USE_PGXS=1 make
USE_PGXS=1 make install

And when I install the extension:
create extension pg_bulkload;

Always show the version 1.0. Then I don't known if exists any fails or I missing any steps.

mikecaat commented

You mean the following results, don't you? It seems a little strange.

$ pg_bulkload --version 
pg_bulkload 3.1.20

psql=# \dx
                                     List of installed extensions
    Name     | Version |   Schema   |                           Description
-------------+---------+------------+-----------------------------------------------------------------
 pg_bulkload | 1.0     | public     | pg_bulkload is a high speed data loading utility for PostgreSQL
 plpgsql     | 1.0     | pg_catalog | PL/pgSQL procedural language
(2 rows)
cesarjorgemartinez commented

I see the PR but, I have a doubt, you would be force for each version to change manually this.

zwyan0 commented

I see the PR but, I have a doubt, you would be force for each version to change manually this.

Hi @cesarjorgemartinez ,thank you for your coment.
As you said, the previous code did have to manually modify the version each time, which is stupid.
So I made a modification.

cesarjorgemartinez commented

Great!
Then LGTM

zwyan0 commented

Great! Then LGTM

Thank you for your confirmation.

  • 👍1