ossimlabs/ossim

License headers inconsistent with LICENSE.txt

sebastic opened this issue · 5 comments

sebastic commented

In DaytonaBeach-2.0.0 the headers were relicensed from MIT to LGPL according to changes like this:

@@ -1,14 +1,14 @@
 //*******************************************************************
 // Copyright (C) 2000 ImageLinks Inc.
 //
-// License: MIT
+// License:  LGPL
 //
 // See LICENSE.txt file in the top level directory for more details.
 //
 // Author:  Garrett Potts
 //
 //*******************************************************************
-//  $Id: ossimDoqqTileSource.h 23664 2015-12-14 14:17:27Z dburken $
+//  $Id: ossimDoqqTileSource.h 17932 2010-08-19 20:34:35Z dburken $
 #ifndef ossimDoqqTileSource_HEADER
 #define ossimDoqqTileSource_HEADER
 #include <ossim/imaging/ossimGeneralRasterTileSource.h>
@@ -56,4 +56,3 @@
 };
 
 #endif
-

The license header does not include the license text and instead refers to the LICENSE.txt file which includes the MIT license terms, not the LGPL.

Either the LICENSE.txt file needs to be updated to include the terms of the LGPL (version 2.1+?), or the header changes need to be reverted back to MIT.

rkanavath commented

Looking at change in Line 11, I guess this a mixup during merge.

But this does not end there. a simple grep shows..
https://paste.debian.net/984406/

sebastic commented

The Initial commit of uber-repo is the only commit in the blame for the random selection of files I checked. It is one of the first commits in this git repository.

It looks like the history from SVN was not preserved, there (in trunk) the files still use MIT in their header. Compare for example:

@@ -1,6 +1,6 @@
 //*******************************************************************
 //
-// License: MIT
+// License:  LGPL
 // 
 // See LICENSE.txt file in the top level directory for more details.
 //
@@ -66,4 +66,3 @@
    TYPE_DATA
 };
 #endif
-
rkanavath commented

@gpotts, can you see if there is something left out in the svn-github synchro

sebastic commented

Is the OSSIM project planning to address this issue? It is still present in 2.1.0.

gpotts commented

I have committed a bunch of files that fixes this issue. It will be in the next release but is checked into dev branch