Embedded copy of libjsoncpp

Question

Embedded copy of libjsoncpp

sebastic opened this issue 7 years ago · 9 comments

sebastic commented 7 years ago

Please remove the libjsoncpp embedded copy and/or support using the system provided libjsoncpp library.

Answer 1 · 2017-09-04T14:03:48.000Z

can we agree on removing this and adding a find_package() for libjsoncpp ?

Answer 2 · 2017-09-04T14:14:15.000Z

That should be sufficient, if there are no customizations to the embedded copy.

Answer 3 · 2017-09-04T14:39:48.000Z

I would make a modification to check the system and if not present then build the internal? Make the internal conditional?

Answer 4 · 2017-09-04T14:47:10.000Z

the internal code is using an amalgamated source. can you tell what apps depend on jsoncpp. I see util/ossimShoreLineUtil.cpp. maybe we can disable them just like hdf. the thing it adds additional dependency to projects that follow ossim.

Answer 5 · 2017-09-04T14:58:40.000Z

Gotcha. I didn't put that one in. I need to ask the person that did it and see.

Answer 6 · 2017-09-04T15:01:03.000Z

just sent a message out

Answer 7 · 2017-09-04T15:03:04.000Z

okay. I will pick on this later when you get a response... ;)

Answer 8 · 2017-09-21T14:59:20.000Z

I'm the culprit. Was in hurricane mode here in Florida the last couple of weeks... I'm looking into this today.

Answer 9 · 2017-09-22T17:03:48.000Z

The embedded JSONCPP files were removed and cmake files were created/modified to search for and use external system-installed jsoncpp-devel installation.