bug: Scores aren't submitted for players with space at the end of the nickname.
hzswdef opened this issue · 8 comments
Describe the bug
The score will not submit if the player has space at the end of the nickname, probably issue may cause in other similar cases, but didn't test yet.
To Reproduce
Expected behavior
Submit score.
bancho.py Version
4.7.2
Python Version
3.9.X (Default)
Relevant log output
No response
Additional context
No response
How did you even manage to create an account with such an invalid name
w8, im stupid, i didn't think that might a guweb issue./
2am, im sorry
How did you even manage to create an account with such an invalid name
Anyway, that's possible through the osu! client.
How did you even manage to create an account with such an invalid name
regardless of username it still shouldn't produce this issue during score submission
@hzswdef is there any relevant logs you can post now or attach to the original post? usually when a score fails to submit it will produce an potentially useful error in your console
this is a weird one to fix - the reason this happens is because osu will append a space to the end of the username on score submission if the client believes the user has supporter privileges (used to catch really shitty supporter cheats) and as bancho.py provides osu!direct to all, every user has these client privileges.
bancho.py trims the trailing space from the username in order to make the name searchable, hence why this occurs. not too sure how we could have both supported, if it’s even worth doing; the first and last character of a username being a space should be (and i believe already is) forbidden
oh actually, upon reading i think i have a simple fix. give me like 10 minutes.
the first and last character of a username being a space should be (and i believe already is) forbidden
I thought so too, that's why I don't get why is error exists
https://github.com/osuAkatsuki/bancho.py/blob/master/app/api/domains/osu.py#L1849 There does not seem to be any check for that