oswaldlabs/chef-rundeck

Work with a client/node name of node[:fqdn]

josephholsten opened this issue · 5 comments

When using the "chef-client::config" recipe
And the Chef::Config[:node_name] == node["fqdn"]
Then "/etc/chef/client.rb" has no "node_name" attribute

So when using chef-client -c /etc/chef/client.rb
Then there is an "ArgumentError" with message "Cannot sign the request without a client name, check that :node_name is assigned"

Instead, if the config file contains no client name or node name
chef-client should use "node[:fqdn]"

Looks like we aren't running Chef::Client#run_ohai and Chef::Client#register. That should do the trick.

@josephholsten Thanks, we will start process these PRs shortly. Getting some test specs together first.

@bscott sounds great. I'm not entirely sure how we're going to test this one since we don't know the node_name until the test runs.

Have you looked at chef-zero? It seems ideal for stubbing out a chef server.

@josephholsten I'll look into it but we did add some node data but I'm still fighting with tests. I am trying to get our testing in place so we can start accepting pull requests.

sounds good.