Expand hidden lines bug in demo website
Closed this issue · 5 comments
justanotheranonymoususer commented
Steps to reproduce:
- Go to https://otakustay.github.io/react-diff-view/
- Paste in ORIGINAL TEXT:
x
1
2
3
4
5
6
7
8
9
0
1
2
3
4
5
6
7
x
- Paste in CHANGED TEXT:
y
1
2
3
4
5
6
7
8
9
0
1
2
3
4
5
6
7
y
- See this: https://i.imgur.com/N3bDgmc.png
- Click on one of "Expand hidden 10 lines"
- All 11 lines are expanded.
otakustay commented
Because we have a useMinCollapsedLines call in demo, when the remaining collapsed lines are less than 5, it expands automatically.
This is a visual bug of demo site, we should display a single "expand all lines" decoration when collapsed lines are less than 15, will fix it soon
stale commented
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
justanotheranonymoususer commented
Any plans on fixing it before the bad bot closes this?
…On Sunday, Oct 17, 2:21 PM, wrote:
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: #143 (comment)
otakustay commented
justanotheranonymoususer commented
Thanks. I thought that you'd fix the button to day "expand 11 lines", because not leaving less than 5 lines is actually nice, but your fix is valid too.