otakustay/react-diff-view

[Bug] diff being parsed differently on versions >= 2.4.2

lucasbento opened this issue · 4 comments

lucasbento commented

Hello 👋

I work on the React Native Upgrade Helper and upgrading react-diff-view from version 2.4.2 to anything above returns a different output when calling parseDiff on this diff.

The breaking difference is that the file android/gradle/wrapper/gradle-wrapper.jar has a hunk of newPath: undefined, this behaviour started happening in 2.4.3.

Here's a zip file with the output of both: version-outputs.zip.

otakustay commented

I can reproduce it, going to debug

  • ❤️1
lucasbento commented

thank you, @otakustay!

otakustay commented

I found a bug handling binary delta diff in our parser and fixed it, this fix ships with 3.0.3 which is in a major version 3.x, will you strongly need it to be backported to 2.x or just advance to 3.x which has very little breaking changes?

stale commented

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.