Tabs are being closed when I do not want them to be

Question

Tabs are being closed when I do not want them to be

Closed this issue 3 years ago · 9 comments

My current setup is as below, but tabs are still being closed.

Happy to help debug. It's happened a bunch this weekend.

Thankfully I have been able to recover them using many presses of Cmd+Shift+T

Answer 1 · 2021-03-08T05:26:18.000Z

Do you have more details please? Did it happen at over 30 tabs? If you could please provide more details that would be appreciated. Claus Sent from my phone, kindly forgive the many errors

…

On 8. Mar 2021, at 02:21, Matt Sephton ***@***.***> wrote: My current setup is as below, but tabs are still being closed. Happy to help debug. It's happened a bunch this weekend. Thankfully I have been able to recover them using many presses of Cmd+Shift+T — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

Answer 2 · 2021-03-08T14:32:03.000Z

Yes, it's happened 4 times so far. It happens almost almost every session.

I'm well over 30 tabs
I am just working, browsing, opening and closing tabs as I go
I mostly work with the keyboard, the only mouse interaction is for pointing and clicking links on the page
At some point I notice "where are all my tabs?"
Even my pinned tabs are closed/gone
I have to press Cmd+Shift+T repeatedly to recover them all
Tabs reappear to the left of the current tab, if that helps ascertain how they were closed

My feeling is there is a problem and the tab closing code is being run somehow when it shouldn't be.

As you can probably gather, at this point I am not sure how I feel about the destructive functions this extension has developed. Perhaps they would be better in another extension, a "tab valet"? Then this extension can be read-only, simply counting tabs/windows as it was originally.

Right now I cannot trust the extension to keep my tabs safe, which is not ideal for an extension that should quietly do little in the background.

This seems to be due to a recent change as I never had this problem until recently.

Answer 3 · 2021-03-08T14:56:46.000Z

I see that the latest app store update came out 2 days ago, that coincides with when i started seeing this behaviour.

I hope that helps.

As a workaround I have put 300 in each of the focus boxes. Will report back if that stops it happening.

Answer 4 · 2021-03-08T17:43:56.000Z

3 times in 1 day!

I'm going have to disable the extension before some serious damage is done.

Still happy to help you solve this.

Answer 5 · 2021-03-08T17:51:10.000Z

I'm still open minded that it might not be this extension but something else.

So I've re-enabled the extension.

Answer 6 · 2021-03-08T19:06:42.000Z

Hi Matt, I am so sorry for the trouble, but I am not sure why it would be happening :( I did fuck up with my GitHub process earlier, so things aren't great for me right now and I am too tired to properly look at this. I tried to replicate the issue. As you can tell i have 17 tabs open and I can keep opening tabs. The first one has focus mode disabled. The second one has it on. That's due to some new logic, that prevents the extension from closing tabs, if it is way above the count that was set. In a previous version, if Focus Mode was on and you had set it to 5 (as in this example) it would be super annoying and kill all windows until it hit 5. This is no longer happening for me. Question, how many windows do you have open? I am trying to understand if that might play into it? I also tested with two windows open and Focus Mode enabled and it only closed tabs in the second window, once I had hit 5. I am at an utter loss, but if this is a problem, please disable the extension, I honestly don't want you to lose any work. But if those two buttons are off the popup should show "focus mode" off and in that case the function returns early: if(!shouldAutoClose && !preventNew){ return } So it "shouldn't" be the extension, but I cannot promise you that it isn't. Greetings Claus On Mon, Mar 8, 2021 at 6:51 PM Matt Sephton <notifications@github.com <mailto:notifications@github.com>> wrote: I'm still open minded that it might not be this extension but something else. So I've re-enabled the extension. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKJBYPQ462LW6XGXMF3A4NDTCUFB7ANCNFSM4YYPIPTA>.

Answer 7 · 2021-03-08T20:57:58.000Z

No worries, it's not important in the bigger picture.

3 windows
82 tabs, maybe as high as 100 at times

I also wondered if it's the Tab Space extension, which also has a close tab feature. I ruled that out as it has not been updated for 2 months, so I would have noticed before the last two days. Regardless, I have now turned off the feature in that extension also.

Answer 8 · 2021-03-10T14:20:50.000Z

OK, first: apologies 🙌

I have tracked down the problem!

I recently started using an app that has shortcuts on the Control key
I also use Tab Space Safari Extension that has shortcuts on the Control key
I forgot that Tab Space has shortcuts that close tabs
The shortcut to close tabs is the same as a shortcut in the new app
Tab Space captures the shortcut pressed to quit the other app as key up happens after Safari regains focus (terrible bug)
No problems since disabling shortcut keys in Tab Space
Feature request made on Tab Space repo

Sorry for the false alarm!

🙈

Answer 9 · 2021-03-10T18:27:02.000Z

Hi Matt, While I am super sorry for your trouble, I am happy it wasn't me in the end. I looked over the code and just could not figure out what could cause it. I know how bad I am at code, so I totally planned to look at it in a lot of depth this weekend. Happy to know it wasn't me. Many thanks for confirming this! Claus

…

On 10. Mar 2021, at 15:21, Matt Sephton ***@***.***> wrote: OK, first: apologies! I think I have tracked the problem down. I recently started using an app that has shortcuts on the Control key I also use Tab Space safari extension that has shortcuts on the Control key I forgot that Tab Space has shortcuts that close tabs The shortcut to close tabs is the same as a shortcut in the new app I am using I guess I must be pressing the key when safari has focus No problems since disabling shortcuts in Tab Space Feature request made on Tab Space repo Sorry for the false alarm! 🙈 — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#23 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKJBYPQXOIMGGOW4HAZPRH3TC555HANCNFSM4YYPIPTA>.