[Discuss] design of popover
Closed this issue · 29 comments
My addition of the last snapshot date, causes some UI issues - i.e. could look better. What are your thoughts.
I personally think:
buttons top
last snapshot date with save page button
then the URL bar
would very much appreciate some help here :)
Will take a look!
Have made a few small tweaks:
- switch off focus ring on buttons
- align width of enter label
- change URL placeholder to an actual URL
See: #21
I was wondering about making it look more like a share menu.
Could we use Emoji as icons? Really not sure about this, but:
💾 Save Current Page
🗓 Show Page History
🐓 Open Oldest Snapshot
🐥 Open Newest Snapshot
🗂 Show Domain Files
🗃 Show Domain Data
Current comparison
Share:
WBM:
I am not sure about the emojis, but I do think that the center align of the buttons is "driving me crazy", so I right aligned them and cheated a bit to get them to inset by a certain number of pixels. The look will be this:
I quite prefer that over the center align of the previous look, as it kind of clean it up and makes it significantly less busy
I will however say that you did a fab job picking emjois that would make sense in a charming way.
Left-aligned looked much better!
How about I create proper icons for the items? The emoji was to just give an idea. I would think the proper icons would all be single colour 16x16 icons like I do for toolbar. I just want it to be more like the share menu.
I'll do a mock up.
alright, monochrome icons certainly can work and they have the potential help users have some muscle memory with their selections.
16x16 sounds fine, I will need to adjust the width (and possibly the height) a bit late for some stupid not programming related reason ;) I kind of look forward to that, as it should be a good enhancement.
Icons (First Draft, may tweak or replace once in place)
Alternate icons for "save":
Can we also tighten up the item spacing (button height) to make it look more like share menu?
Good Evening,
I have added those icons and reduced the button height to 20px making things a bit tighter. Not sure it looks more like the share menu.
I need to think what to do with those icons in dark mode, I think I'll simply invert it for darkmode
I might do that later
that looks a bit better in dark mode ;)
Ooh! Nice.
I'll do some minor tweaks today, and maybe try some alternate icons.
But I like it!
(you need to commit your changes)
Everything should be committed - there are no uncommitted changes for me in GitHub Desktop - you sure they are not committed?
Double checked and my commits are there. Please note one thing about the icons.
I am using some whitespace to the left to move the button in. I tried hard with an inset, but I couldn't get it to work and thus decided to cheat ;)
I am off this afternoon, so if you have anything you want me to look at, let me know. Otherwise I am working on getting the "Recommender from core.ac.uk" to work in OA Helper for iOS ;)
Got them thanks — user error "not enough coffee"
Text in menus is blue in non-Dark mode.
How do I put more space between the icon and the text?
I need to come clean, I was unable to figure out the spacing, so I am simply going to suggest - simply add more "transparent space" in the image...
The text for me is black - what OS are you in?
Mojave 10.14.6
Will look at spacing.
mmmh, I might have to try on my other computer tomorrow then
committed a change, that replaces .textColor with .windowFrameTextColor - haven't checked out the color in macOS 10.15 yet - but hope that things look "good" for you as well
Going to change the images soon, but I noticed they are not sharp pixels so I am wondering if there is a better size for them to be? Thoughts appreciated.
I might have "ruined it", when I rescaled the images. I honestly don't know. However, if we wanted to submit the app soon, we best do it before the weekend, otherwise it will be a 2020 thing. I am quite ok with that, but just wanted to shape your expectations (App Store Connect will shut down for about a week over Christmas)
I'll take a look, but let's submit before that deadline.
I'm happy.
Hi Matt,
I am somewhat confused about where we left things. Should we ship without new icons, or will you have time to create new ones? Sorry to be bugging you like this / I have no urgency to submit this, other than that I don't want this project to end up in an "unfinished" state :) After all I want our good work to shine ;)
Let's ship it! Time has run away from me.
I will improve the icons in future.
👍 I did submit it, far from perfect, but we can always update later.
Should we not get to exchange any messages before the holidays: Happy Christmas, Happy Hanukkah, Happy New Year :)
And to you and yours my friend