why does zora use `ipfs://` IANA scheme?
TimDaub opened this issue · 2 comments
TimDaub commented
- I know this is probably not the right repository
- When crawling zora contracts at neume.network, I'm finding that many URIs are in the format of
ipfs://
and so naively I've assumed that this is an IANA-official format. I even remember @jbenet talking about it years ago - But I looked into the IPFS code briefly and I couldn't find any indication that indeed the IANA
ipfs://
scheme is supported: ipfs-shipyard/is-ipfs#48 (comment) - The is-ipfs readme further confirms this: https://github.com/ipfs-shipyard/is-ipfs#usage
- but IANA has a definition: https://www.iana.org/assignments/uri-schemes/uri-schemes.xhtml
- But I saw in your code that you're replacing it with the gateway location:
nft-hooks/src/fetcher/UriUtils.ts
Line 5 in 6f0b963
- So are you doing this because the official ipfs https client doesn't support the
ipfs://
IANA scheme?
TimDaub commented
- Sent a PR to ipfs-shipyard on this: ipfs-shipyard/is-ipfs#51
iainnash commented
We're doing this in NFT hooks since browsers cannot handle ipfs://
URI schemes with a gateway natively.
The ipfs://
scheme isn't IANA but is supported by most all major NFT marketplaces and recommended as a best-practices thing.