askcreds - fails to compile

Question

askcreds - fails to compile

jabra- opened this issue 3 years ago · 14 comments

Askcreds.c: In function ‘AskCreds’:
Askcreds.c:111:9: error: ‘CREDUIWIN_GENERIC’ undeclared (first use in this function); did you mean ‘CRED_TYPE_GENERIC’?
         CREDUIWIN_GENERIC | CREDUIWIN_CHECKBOX
         ^~~~~~~~~~~~~~~~~
         CRED_TYPE_GENERIC
Askcreds.c:111:9: note: each undeclared identifier is reported only once for each function it appears in
Askcreds.c:111:29: error: ‘CREDUIWIN_CHECKBOX’ undeclared (first use in this function); did you mean ‘CREDUI_INFO’?
         CREDUIWIN_GENERIC | CREDUIWIN_CHECKBOX
                             ^~~~~~~~~~~~~~~~~~
                             CREDUI_INFO

Answer 1 · 2022-04-22T15:50:47.000Z

How do you compile? Tools should compile successfully on latest version of Kali/Mac OSX with latest version of Mingw-w64 compiler.

Answer 2 · 2022-04-22T15:54:19.000Z

OS: debian buster.
used make to compile.
All of the other BOFs compiled just fine.

Answer 3 · 2022-04-22T15:59:19.000Z

+#define CREDUIWIN_GENERIC 0x1
+#define CREDUIWIN_CHECKBOX 0x2

fixes it.
ref: https://github.com/kinke/mingw-w64-crt/blob/master/mingw-w64-headers/include/wincred.h#L327

Answer 4 · 2022-04-25T08:27:07.000Z

Same issue here with Ubuntu 20.04.3 LTS

Answer 5 · 2022-04-25T08:40:56.000Z

Tools have been tested (and compiled) successfully on Kali (latest) and mac OSX with Mingw-w64 installed (see support note in readme). I hope the above #define change fixes the issue on Debian/Ubuntu otherwise I recommend compiling the tools on a Kali VM.

Answer 6 · 2022-04-25T08:43:10.000Z

@Cn33liz indeed, the target is to build on Kali but I was using Ubuntu 20.04 for dev and noticed the issue. I thought it would be interesting to add a reference here if others have the same issue 😉
The #define change fixes the issue

Answer 7 · 2022-04-25T08:45:27.000Z

Good point, i'll add this to the readme, thank you :)

Answer 8 · 2022-04-25T09:05:59.000Z

Added the proposed solution to an issue section within the readme file. If this is okay with you both then i'll close the issue?

Answer 9 · 2022-04-25T14:08:57.000Z

Why not just add these to your .h header?

Here is a reference from microsoft:
https://docs.microsoft.com/en-us/windows/win32/api/wincred/nf-wincred-creduipromptforwindowscredentialsa

Answer 10 · 2022-04-25T20:59:26.000Z

FYI I've tried with Kali 2022.1 from a few months old (missing lot of updates) and it was giving the same error as above.
After upgrading the system, the error was no longer showing up.

Answer 11 · 2022-04-26T08:29:04.000Z

I added the #defines to the header file. Can you verify if everything is working as expected now?

Answer 12 · 2022-04-26T09:41:24.000Z

Looks like it's working now, on Ubuntu 20.04 as well, thanks! 😄

Answer 13 · 2022-04-26T11:41:11.000Z

great! compiles perfectly now. good to close.

Answer 14 · 2022-04-26T12:17:58.000Z

Great thanks for the feedback!