outfoxxed/hy3

[BUG] Fails to build on latest commit -- Mismatched types

halperyon opened this issue · 4 comments

  • Install method: hyprpm
  • Distro: Artix on Bedrock (tested on standard Arch too)
  • Package Versions
hyprland hyprlang
0.39.1-5 0.5.1-1

Installation log

$ hyprpm add -v https://github.com/outfoxxed/hy3

Date: Tue Apr 16 16:01:03 2024
Tag: v0.39.1, commits: 4460

flags: (if any)


[v] parsed commit fe7b748eb668136dd0558b7c8279bfcd7ab4d759 at branch  on Tue Apr 16 16:01:03 2024, commits 4460
✔ adding a new plugin repository from https://github.com/outfoxxed/hy3
  MAKE SURE that you trust the authors. DO NOT install random plugins without verifying the code and author.
  Are you sure? [Y/n] y

 → Cloning https://github.com/outfoxxed/hy3                                                                                                                                      
✔ cloned                                                                                                                                                                         
✔ found hyprpm manifest                                                                                                                                                          
✔ parsed manifest, found 1 plugins:                                                                                                                                              
 → hy3 by outfoxxed version                                                                                                                                                      
 → Manifest has 7 pins, checking                                                                                                                                                 
✔ commit pin 6f9719291386d5e3baad211420d60e54e9967ee6 matched hl, resetting                                                                                                      
✔ Hyprland headers OK                                                                                                                                                            
 → Building hy3                                                                                                                                                                  
 ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━╍━━━━━━━━━━━━━━━━━━━  3 / 5  Building plugin(s)[v] shell returned:  -> cd /tmp/hyprpm/new && PKG_CONFIG_PATH="/home/user/.local/share/hyprpm/headersRoot/share/pkgconfig" cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo -B build
-- The C compiler identification is GNU 13.2.1
-- The CXX compiler identification is GNU 13.2.1
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Found PkgConfig: /usr/bin/pkg-config (found version "2.1.1")
-- Checking for modules 'hyprland;pixman-1;libdrm;pango;pangocairo'
--   Found hyprland, version 0.39.1
--   Found pixman-1, version 0.43.4
--   Found libdrm, version 2.4.120
--   Found pango, version 1.52.2
--   Found pangocairo, version 1.52.2
-- Configuring done (0.6s)
-- Generating done (0.0s)
-- Build files have been written to: /tmp/hyprpm/new/build

the important part/where it fails

 -> cd /tmp/hyprpm/new && PKG_CONFIG_PATH="/home/user/.local/share/hyprpm/headersRoot/share/pkgconfig" cmake --build build
[ 14%] Building CXX object CMakeFiles/hy3.dir/src/main.cpp.o
[ 28%] Building CXX object CMakeFiles/hy3.dir/src/dispatchers.cpp.o
/tmp/hyprpm/new/src/dispatchers.cpp: In function ‘int workspace_for_action(bool)’:
/tmp/hyprpm/new/src/dispatchers.cpp:12:59: error: cannot convert ‘PHLWORKSPACE’ {aka ‘std::shared_ptr<CWorkspace>’} to ‘int’ in initialization
   12 |         int workspace_id = g_pCompositor->m_pLastMonitor->activeWorkspace;
      |                            ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~
      |                                                           |
      |                                                           PHLWORKSPACE {aka std::shared_ptr<CWorkspace>}
/tmp/hyprpm/new/src/dispatchers.cpp:15:58: error: unable to deduce ‘auto*’ from ‘CCompositor::getWorkspaceByID(const int&)(workspace_id)’
   15 |         auto* workspace = g_pCompositor->getWorkspaceByID(workspace_id);
      |                           ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~
/tmp/hyprpm/new/src/dispatchers.cpp:15:71: note:   mismatched types ‘auto*’ and ‘std::shared_ptr<CWorkspace>’
   15 |         auto* workspace = g_pCompositor->getWorkspaceByID(workspace_id);
      |                                                                       ^
make[2]: *** [CMakeFiles/hy3.dir/build.make:90: CMakeFiles/hy3.dir/src/dispatchers.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:83: CMakeFiles/hy3.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
✖ Plugin hy3 failed to build.                                                                                                                                                    
  This likely means that the plugin is either outdated, not yet available for your version, or broken.
  If you are on -git, update first.
  Try re-running with -v to see more verbose output.

I'm seeing the same thing on Fedora (40) and Hyprland 0.39.1 (0.39.1-2.fc40)

Installing the repo from this PR fixes it for me #101

I don't really like using a non-official repo but oh well

Same build error here as well

Just tried building right now and yeah.. same error
Building with this PR for now #101