Adopt UNIX newline convention
fernandoacorreia opened this issue · 2 comments
The codebase is mixing WINDOWS and UNIX newline conventions. Some files are using CR+LF and others just LF.
For consistency, all files should be converted to UNIX newlines. On Windows, MSysGit seamlessly converts to and from native newlines.
That's odd. Can you point me to an example?
On a Linux system:
$ git clone https://github.com/hueniverse/postmile.git
Cloning into postmile...
remote: Counting objects: 563, done.
remote: Compressing objects: 100% (413/413), done.
remote: Total 563 (delta 326), reused 359 (delta 122)
Receiving objects: 100% (563/563), 2.09 MiB | 103 KiB/s, done.
Resolving deltas: 100% (326/326), done.
$ cd postmile/
$ find . -type f -exec grep -Pl '\r' {} ;
./api/sort.js
./api/invite.js
./api/task.js
./api/base64.js
./api/session.js
./api/email.js
./api/package.json
./api/last.js
./api/install.js
./api/error.js
./api/db.js
./api/rules.js
./api/batch.js
./api/log.js
./api/user.js
./api/routes.js
./api/vault.js.example
./api/suggestions.js
./api/stream.js
./api/project.js
./api/index.js
./api/server.js
./api/storage.js
./api/tips.js
./api/details.js
./api/utils.js
./postmile.js
./clients/view/js/history.js
./clients/view/js/uiutils.js
./clients/view/js/tour.js
./clients/view/js/overlay-extras.js
./clients/view/js/settings.js
./clients/view/js/contacts.js
./clients/view/js/user.js
./clients/view/js/tooltips.js
./clients/view/js/suggestions.js
./clients/view/js/stream.js
./clients/view/js/projectslist.js
./clients/view/js/project.js
./clients/view/js/menu.js
./clients/view/js/tasklist.js
./clients/view/js/dnd.js
./clients/view/js/load.js
./clients/view/js/authentication.js
./clients/view/js/network.js
./clients/view/js/templates.js
./clients/view/js/global.js
./clients/view/js/mac.js
./clients/view/js/tips.js
./clients/view/js/calendar.js
./clients/view/images/background.png
./clients/view/images/colage.png
./clients/view/images/tasks-loading.gif
./clients/view/images/suggestions-loading.gif
./clients/view/images/mountains.png
./clients/view/images/line.png
./clients/view/images/tour-assign.png
./clients/view/images/tour-checkbox.png
./clients/view/images/tour-assigned.png
./clients/view/images/tour-comments.png
./clients/view/client.json
./clients/view/client.json.example
./web/test.js
./web/base64.js
./web/session.js
./web/email.js
./web/package.json
./web/api.js
./web/signup.js
./web/error.js
./web/client.js
./web/log.js
./web/routes.js
./web/vault.js.example
./web/home.js
./web/index.js
./web/login.js
./web/server.js
./web/misc.js
./web/account.js
./web/views/feedback.jade
./web/views/stupid.jade
./web/views/developer.jade
./web/views/console.jade
./web/views/oauth.jade
./web/views/error.jade
./web/views/about.jade
./web/views/invite-invalid.jade
./web/views/home.jade
./web/views/register.jade
./web/views/invite-out.jade
./web/views/account-emails.jade
./web/views/layout.jade
./web/views/account-linked.jade
./web/views/login.jade
./web/views/invite-in.jade
./web/views/account-profile.jade
./web/views/tos.jade
./web/static/images/facebook-footer.png
./web/static/images/background.png
./web/static/images/colage.png
./web/static/images/withstupid.png
./web/static/images/gradient-dev.png
./web/static/images/404.png
./web/static/images/button_verify_up.png
./web/static/images/icon_twitter.png
./web/static/images/twitter-footer.png
./web/static/images/black-35.png
./web/static/images/500.png
./web/static/images/button_verified.png
./web/static/images/mobile/button_twitter.png
./web/static/images/mobile/button_facebook.png
./web/static/images/mobile/logo.png
./web/static/images/mobile/bg.png
./web/static/images/mobile/button_yahoo.png
./web/static/images/mobile/box.png
./web/static/images/snow-dev.png
./web/static/images/button_verify_over.png
./web/static/images/mountains.png
./web/static/images/unknown.png
./web/static/images/buttons_disconnect.png
./web/static/images/logo.png
./web/static/images/buttons_connect.png
./web/static/images/ajax-loader.gif
./web/static/images/icon_facebook.png
./web/static/images/mountains-dev.png
./web/static/images/warning.png
./web/static/images/gray-95.png
./web/static/images/icon_yahoo.png
./web/static/css/base.css
./web/static/scripts/base.js
./web/static/scripts/mac.js
./web/static/robots.txt
./web/utils.js
./web/tos.js
./.git/objects/pack/pack-aedd17e861538823d9bf848f99c1fe40b4b08263.pack
./.git/objects/pack/pack-aedd17e861538823d9bf848f99c1fe40b4b08263.idx
./.git/index
./config.js.example
./LICENSE
./Readme.md
$ vi api/sort.js
/*
- Copyright (c) 2011 Yahoo! Inc. All rights reserved. Copyrights licensed under the New BSD License.^M
- See LICENSE file included with this code project for license terms.^M
*/^M
^M
// Load modules^M
^M
var Db = require('./db');^M
var Utils = require('./utils');^M
var Err = require('./error');^M
^M
^M
// Get ordered items list^M
^M
exports.list = function (collectionName, listId, key, callback) {^M
^M
var criteria = {};^M
criteria[key] = listId;^M
^M
Db.query(collectionName, criteria, function (items, err) {^M
^M
if (err === null) {^M
^M
Db.get(collectionName + '.sort', listId, function (item, err) {^M
^M