ovn-org/ovn-kubernetes

e2e EgressQoS validation -- account for single stack cluster

flavio-fernandes opened this issue · 2 comments

flavio-fernandes commented

What would you like to see added/updated/deleted in our end-to-end tests?

In a cluster where only ipv4 (or ipv6) is deployed, the e2e tests for EgressQoS validation should skip tests on family that is not configured:

$ cd .../ovn-kubernetes.git/contrib && \
  KIND_IPV6_SUPPORT=false ./kind.sh -ic -ds && echo ok

$ cd ../test/e2e && \
   go mod download && \
   go test -test.timeout 5m -v . -ginkgo.v \
   -ginkgo.focus 'e2e\sEgressQoS\svalidation' \
   -ginkgo.flake-attempts 1 -ginkgo.fail-fast \
   -provider skeleton -kubeconfig $KUBECONFIG --num-nodes=2 && echo ok

...

• [FAILED] [6.906 seconds]
e2e EgressQoS validation Should validate correct DSCP value on EgressQoS resource changes [It] ipv6 pod before resource
/home/vagrant/dev/ovn-kubernetes.git/test/e2e/egressqos.go:171

[FAILED] error running /usr/local/bin/kubectl --server=https://127.0.0.1:33455 --kubeconfig=/home/vagrant/admin.conf --namespace=egressqos-4476 create -f egressqos.yaml:
Command stdout:

stderr:
The EgressQoS "default" is invalid: spec.egress[0].dstCIDR: Invalid value: "/128": spec.egress[0].dstCIDR in body must be of type cidr: "/128"

error:
exit status 1
In [It] at: /home/vagrant/go/pkg/mod/k8s.io/kubernetes@v1.29.2/test/e2e/framework/kubectl/builder.go:91 @ 07/01/24 17:51:06.086

Why is this needed?

Should be able to gracefully handle single stack clusters.

github-actions commented

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 5 days.

github-actions commented

This issue was closed because it has been stalled for 5 days with no activity.