owebia/magento1-module-advanced-shipping

Switch-case in parseSize method has no break

Closed this issue · 1 comments

adrian3d commented

Hey !

I made a pull request concerning parseSize method in ConfigParser class. After a reading of the code, I'm really surprised to see the switch-case has no break. The calc on the $size is executed 3 times.

Is it a mistake? Or is it normal?

Thanks.

owebia commented

Hi,
This is normal.
Regards,