owenthereal/gh

Full hub compatibility

owenthereal opened this issue · 8 comments

owenthereal commented

We're not 100% compatible with hub yet. Let's make it happen! There're some tests flagged as "@wip". We need to minimize those.

  • authentication
  • browse
  • clone
  • create
  • fork
  • pull request
  • remote add
  • submodule add
calavera commented

It turns out that submodule add was already completely working as expected, so I just removed the wip mark 😄

calavera commented

Oh, weird, it fails on travis, I'm going to double check it.

owenthereal commented

I just checked. It passed locally for me too. Maybe that's why I disabled it at the first place.

calavera commented

@jingweno so, the remaining issues are related to the fact that we don't use ssh by default on clones. As we already discussed in #117 I don't think that it should be the default option, so I'm going to leave it up to you, I'll be fine either way.

owenthereal commented

@calavera I'm happy with what it is now. Flagging it done

calavera commented

@jingweno the remote add remaining issue is also the same as the clone issue 😄

owenthereal commented

Just in time for 2014! Flagged it done!