gh pull-request no longer adds commit messages to default PR message
Peeja opened this issue · 11 comments
Previously, gh pull-request would prefill the PR title/message with the message of the commit (if there's only one) or with the commented-out messages of all the commits (if there's more than one). Recently it's stopped doing that. It just says
# Requesting a pull to foo:master from foo:branch
#
# Write a message for this pull request. The first block
# of the text is the title and the rest is description.
This change happened without upgrading or reinstalling gh, so I assume this is due to a GitHub API change. It sounds like some things changed a couple of months ago? That would fit the timeframe of this issue.
@Peeja It actually works for me. What's the output of gh -v? Please note that it'll only prefill the PR/ title/message if there's only one commit.
Huh. The output is "Unknown option: -v".
Ooops...should be gh version
Ah:
git version 1.8.3.4 (Apple Git-47)
gh version 2.0.0
Aha: I think I only see this when I'm PRing between branches in the same repo. Across repos it seems to work correctly for me.
@Peeja I assume you meant to say not working across repos? :)
No, it's failing when I make a PR across branches in the same repo. Or, at least, I only see it fail on the only project I make same-repo PRs on. I haven't played with it enough to be certain that's why.
I'm seeing the same issue. Any idea what could be causing this?
Whoops. Looks like my issue was because I was defining a base that included the organization. git pull-request -b org/branch results in an error, but git pull-request -b branch works properly.
I'm not seeing this anymore, but I am seeing #229. @kevinthompson, are you still seeing this?
Closing it. Thanks for confirming.