Opts table is not effective
Closed this issue · 8 comments
I'm trying to pass opts table to the setup function but it doesn't seem to be effective
Example config:
Trying to disable italics and enabling transparent background.
Just took a look at the source code, and here's what I noticed
at theme.lua file:
tried to inspect the value of settings.italics for example
It initially reads my custom value which is false then immediately it is been set to true which I guess is the default
I'm suspecting that this line might be responsible for calling the setup function with an empty table which will always set the defaults values again.
@andrew-george Thanks so much for reporting this. I'll take a look and make sure the setup function works as expected.
@andrew-george are you by any chance setting the colorscheme somewhere else in your config?
@oxfist Sorry for the late reply.
I use lazy so I usually install and configure colorschemes in lazy table and apply it using vim.cmd in another separate file
Hi @andrew-george, I just pushed some changes that should get this fixed. I tried it with a minimal lazy config and got the expected result, i.e. if settings italics = false in the setup call, then it disables de italics correctly. Could you please test this on your end?
Thank you for your fast response and fix. It's now indeed working flawlessly.
@all-contributors please add @andrew-george for bug
I've put up a pull request to add @andrew-george! 🎉