The problem is that the state of the `EMGFilters` filters is stored in the global variables `LPF`, `HPF` and `AHF`. These being globals means that all instances of `EMGFilters` share their internal state.

Question

The problem is that the state of the `EMGFilters` filters is stored in the global variables `LPF`, `HPF` and `AHF`. These being globals means that all instances of `EMGFilters` share their internal state.

Opened this issue 3 years ago · 1 comments

The problem is that the state of the EMGFilters filters is stored in the global variables LPF, HPF and AHF. These being globals means that all instances of EMGFilters share their internal state.

The filter state should be stored as instance data. Otherwise all instances effectively share the same filter.

Originally posted by @edgar-bonet in #3 (comment)

@edgar-bonet Oh. I'm sorry. Because of your fix, I thought the problem was solved and closed it. It seems that I did not follow the Github rules. Now I re-open the issue.

Answer 1 · 2022-04-19T08:26:16.000Z

@allrobot: #4 is a proposed fix. The problem will be solved if/when a fix is accepted by the owners of the project and merged into the master branch.