getZoneId is always using the ZONE environment variable, even when ZONE_FILE is set.
devantler opened this issue · 4 comments
I am currently setting up a repo for easily setting up a fully managed cluster with Portainer and Docker Swarm. Right now I am using this service to update DDNS on Cloudflare as it is very helpful in avoiding dependency on scripts or router-based DDNS updates.
Because my repo is planned to be public I want to ensure all sensitive information is added with Docker Secrets. Right now the ZONE_FILE and SUBDOMAIN_FILE are not working with Docker Secrets which requires me to write the values in the compose file using ZONE and SUBDOMAIN environment variables.
The API_KEY_FILE works just fine, so i think it is an easy fix :-)
The fix should enable Docker Secret users to only have to add the ***_KEY_FILE variables as they overwrite the non KEY_FILE variables, and as such the non KEY_FILE variables are not required.
To fix this I believe getZoneId should have a parameter so that the correctly populated ZONE value in 30-cloudflare-setup.sh can be passed along, when ZONE is set from ZONE_FILE.
Yes I found the same thing. API_KEY_FILE works just fine with a Docker secret via CLI or Compose while ZONE_FILE and SUBDOMAIN_FILE do not work. The README suggests that the latter two are supported while the docs on Docker Hub do not mention them.
Thanks for this project by the way - very handy!