p-j/meteor-gravatar

Consider normalizing the email address for Gravatar

dandv opened this issue · 5 comments

dandv commented

If the user registers with a sub-address (e.g. joe+yourapp@gmail.com), Gravatar isn't smart enough to find the picture of joe@gmail.com.

We've just released a package to correct for that, idorecall:email-normalize. I can proudly say that it's the best solution I've seen so far for this problem, as it supports not just Gmail, but any domain hosted with Google Apps for Work (via an MX DNS lookup), plus FastMail, Microsoft, Yahoo! and others.

p-j commented

Thanks for the pointer @dandv.

I'll certainly integrate that, it's an inconvenience I've had to deal with myself and the solution is elegant.
I'll have to test for the original email before though as the user may want to use separate Gravatar for two sub-address.

dandv commented

Correct - made a note about that.

p-j commented

Actually, a clever way of doing it could be to ask for the gravatar with the sub-address and use the d parameter with the standard address.
That being a default setting that the package user can override if he wanted.

What do you think ?

dandv commented

That looks like a nifty idea, esp. if the pass through the user's d to the very end:

p-j commented

I've integrated this feature in this commit faec93b

Thanks for your help !