p2sr/wormhole

Hardcoded interface versions

ThisAMJ opened this issue · 0 comments

The version of ISERVERPLUGINCALLBACKS is hardcoded to 003 in wormhole currently, where it should support any version for compatibility. SST does this to a point, but only for the last digit!!!! Also worth considering is the ISERVERPLUGINHELPERS001 interface, and the nature of the ClientFullyConnect vtable entry.

wormhole/src/main.zig

Lines 147 to 150 in 8da8708

if (!std.mem.eql(u8, std.mem.span(name), "ISERVERPLUGINCALLBACKS003")) {
if (ret) |r| r.* = 0;
return &callbacks;
}

https://github.com/mikesmiffy128/sst/blob/13ad0442a3fde0518ca9133b55796f31652698c9/src/sst.c#L438-L444