p5-serial/p5.serialserver

Sample code generated does not work

tigoe opened this issue · 2 comments

tigoe commented

Here's the process for testing:

  1. open p5.serialcontrol
  2. scan for ports
  3. open a port
  4. Copy serial code as generated
  5. paste into a new sketch at https://editor.p5js.org
  6. add CDN link after line 6 of index.html: <script language="javascript" type="text/javascript" src="https://cdn.jsdelivr.net/npm/p5.serialserver@0.0.28/lib/p5.serialport.js">
  7. Save
  8. Close serial port in serialcontrol app.
  9. Click Run

Result: sketch does not run.

tigoe commented

Solution: the CDN link mentioned on the main readme page needs a closing </script> tag.

js6450 commented

Added closing tag in the readme file!