pachadotdev/eflm

Patrick 0.1.0 will have backwards incompatible changes

michaelquinn32 opened this issue · 2 comments

michaelquinn32 commented

Hi Pacha!

Thanks for using patrick for creating parameterized tests.

I am going to start the process of releasing a backwards incompatible change in the package.

  • In the past, the undocumented test_name parameter could be used to in cases data frames and as an argument for naming tests
  • I am moving this to a documented argument in with_parameters_test_that(). The argument is also getting the name .test_name in order to distinguish it from test cases passed by a user

In version 0.1.0, patrick will throw a warning about this change and rename input as appropriate. In the future, this warning will be dropped. Addressing it requires changing your use of test_name to .test_name.

Apologies for any inconvenience that this causes. Please let me know how else I can help.

Best wishes,
Michael

pachadotdev commented

Hi Pacha!

Thanks for using patrick for creating parameterized tests.

I am going to start the process of releasing a backwards incompatible change in the package.

* In the past, the undocumented `test_name` parameter could be used to in cases data frames and as an argument for naming tests

* I am moving this to a documented argument in `with_parameters_test_that()`. The argument is also getting the name `.test_name` in order to distinguish it from test cases passed by a user

In version 0.1.0, patrick will throw a warning about this change and rename input as appropriate. In the future, this warning will be dropped. Addressing it requires changing your use of test_name to .test_name.

Apologies for any inconvenience that this causes. Please let me know how else I can help.

Best wishes, Michael

thanks a lot! i'll change fixest PR as well

pachadotdev commented

@michaelquinn32 I finally patched this here db48ba8

My way of testing is a bit particular, the ~1000 tests are actually very compact