pact-foundation/pact_broker

Can-i-deploy fails even when there is a successfull verification result

vblahoz opened this issue · 3 comments

The can-i-deploy response contains single verification result in the matrix whitch is successful.
The summary claims there is one verification with success and one with unknown status.
The error says "There is no verified pact between the latest version of producer_app with tag production (036b8bcd3a43808f87e2cc22af63ae1e6bb65ab0) and version c1db00bd1a15c014826be2c79ec4fec94cff377b of consumer_app" which is clearly not true (see the matrix in the response)

I have already (please mark the applicable with an x):

  • Upgraded to the latest Pact Broker OR
  • Checked the CHANGELOG to see if the issue I am about to raise has been fixed
  • Created an executable example that demonstrates the issue using either a:
    • Dockerfile
    • Git repository with a Travis or Appveyor (or similar) build

Software versions

  • pact-broker docker version: 2.93.2.0
  • pact broker client details: pact-ruby-standalone CLI v 1.4.0

Expected behaviour

can-i-deploy check succeeds when there is successfull relevant verification between required versions of participants

Actual behaviour

can-i-deploy claims the consumer version is not deployable with an error even with successfull verification in the matrix

Relevant log files

can-i-reploy-result.txt

Hi. Apologies that it's taken me so long to reply to this. I can't do much to identify the issue without the correct data. Can you recreate the scenario using this please? https://github.com/pact-foundation/pact_broker/blob/master/ISSUES.md

Just having a quick look through the json, I think you have duplicate providers. In the error message, it says "producer_app", but in the links, I see "producer-app".

"There is no verified pact between the latest version of producer_app with tag production (036b8bcd3a43808f87e2cc22af63ae1e6bb65ab0) and version c1db00bd1a15c014826be2c79ec4fec94cff377b of consumer_app"
https://pactbroker.com/pacticipants/producer-app/versions/036b8bcd3a43808f87e2cc22af63ae1e6bb65ab0/tags/development

hi @vblahoz,

This should be resolved now, haven't had a chance to test, but have assigned myself so will do, and close off these issues

Relevant website documentation is here

https://docs.pact.io/pact_broker/configuration/features#checking-for-potential-duplicate-pacticipant-names

Thanks Beth!