pact-foundation/pact_broker

Vendorise sucker_punch with fix for singleton_class? error

Closed this issue · 5 comments

Due to inactivity on brandonhilkert/sucker_punch#252, we should embed the sucker_punch gem code inside the pact_broker gem, with the proposed fix.

yes please!

installing gems from git is an issue in

Now it's an issue for me in my adventures because the packaging tools can't find gems installed from git because bundler puts them in a different place.

The proper fix for that issue would be to I assume put the gems from the git folder in the load path, but I'm already shaving juggling several yaks that need shaving, this is just a nice way out as an interim.

Would the view be to unvendor, when the proposed change is merged?

Yes, we'd want to go back to the real one when possible.

Danke for confirming, thought so.

btw sorted my load path errors with require "bundler/setup" when loading a Gem from a bin path in a script (coupled with setting the BUNDLE_GEMFILE env var so its requiring the right gems. Bundler setups the git gems in the correct path)

Resolved by #664 as the proposed PR against sucker_punch has now been merged 🚀