pafuhana1213/KawaiiPhysics

AdjustByAngleLimit is not working properly

dopieters opened this issue · 1 comments

I have noticed that the function AdjustByAngleLimit in AnimNode_KawaiiPhysics.cpp is not working properly. The bug seems to be due to the use of the function RotateAngleAxis which rotate around a normalized vector. Currently the vector is not normalized. So it can be fixed by changing BoneDir = BoneDir.RotateAngleAxis(-AngleOverLimit, Axis); by:

const FVector AxisNormalized = Axis.GetSafeNormal();
BoneDir = BoneDir.RotateAngleAxis(-AngleOverLimit, AxisNormalized);

Hi @dopieters !
I'm appreciate your report and great modified code!

I've committed 9a0576c to fix this issue now.

Thanks!