Comprehend Sugared AMD Modules

Question

Comprehend Sugared AMD Modules

EisenbergEffect opened this issue 12 years ago · 17 comments

With require.js, you can write AMD modules using the sugared syntax:

define(function(require){
var mod1 = require('mod1') ;
});

I've run madge over a project which uses this, but it only seems to detect the top most module dependencies and not the rest.

Answer 1 · 2012-12-20T21:30:41.000Z

I'm using this style myself in a project and it seems to work pretty well for me. Can you give me a more detailed example so I can try to reproduce it?

Answer 2 · 2012-12-20T21:34:36.000Z

Well, then....it's highly likely I just have no idea what I'm doing 😄 Here's a link to the code I was trying to generate a graph of: https://github.com/EisenbergEffect/Durandal/tree/master/app/durandal

Let me know if I can help any other way. Thanks!

Answer 3 · 2012-12-21T19:42:10.000Z

Hehe, I'm sure you know what you're doing :) I tried running madge on your project and it seems to be working as expected for me. Am I missing something in your code?

$ madge -f amd -i graph.png app/durandal

http://cl.ly/image/1P1K2Y1e2O0x

$ madge -f amd app/durandal
app
  composition
  dom
  events
  messageBox
  modalDialog
  system
  viewEngine
  widget
composition
  system
  viewEngine
  viewLocator
  viewModelBinder
dom
  system
events
  system
http
messageBox
modalDialog
  composition
  system
  viewModel
system
viewEngine
  dom
  text
viewLocator
  system
  viewEngine
viewModel
  system
viewModelBinder
  system
widget
  composition
  system

Answer 4 · 2012-12-21T20:04:20.000Z

Well, would you look at that!? It works! I think I must have been using the command incorrectly. I'll give it a try myself and see what happens.

Answer 5 · 2012-12-21T20:16:48.000Z

Ok. I tried it on my machine and I get something different:

app
composition
dom
events
messageBox
modalDialog
system
viewEngine
widget

It's like it's only tracing the app module and not the other modules. I'm running this on Windows...could that be related?

Answer 6 · 2012-12-21T20:42:06.000Z

Hmm, that's weird! I never tried it in windows before .. I'll boot up my virtual machine and give it a try!

Answer 7 · 2012-12-21T21:27:15.000Z

I tried it now, and confirmed it's a problem when running madge on Windows :( To much modules that I use seems to be incompatible with Windows at this time. I can't even run the unittests. Run it on Mac or Linux and it should be ok.

Answer 8 · 2012-12-21T21:36:38.000Z

Well, that's unfortunate. Hopefully that can be remedied in the future. For now, the image you generated will actually work for me. When I need a new image...I'll swipe my wife's mac while she's not looking ;) Thanks for looking into this issue and for working on this project!

Answer 9 · 2013-01-09T01:15:50.000Z

I also was having this issue and traced it to an issue with the dependent library findit: https://github.com/substack/node-findit/issues/5

If you modify the index.js file within the findit library (as mentioned in the link above) you can enable a workaround and get madge file enumeration to work on windows.

findit in turn is using node libraries for file enumeration so a related issue is opened in the node libuv package
joyent/libuv#613

Per comments in the original issue, an alternative file enumerating library may work on windows, but would be up to pahen if he wants to change to it: https://github.com/soldair/node-walkdir

Answer 10 · 2013-01-10T20:41:42.000Z

Thanks very much @israels for looking into this issue. Since the API of node-walkdir was compatible with node-findit I've now done the switch and it seems to work just fine. Tested it in Windows too, and it works much better now. I published v0.1.4 to NPM with the fix. @EisenbergEffect may be interested to give it a spin again now I suppose :)

Answer 11 · 2013-01-10T20:47:58.000Z

Awesome!

On Thu, Jan 10, 2013 at 3:41 PM, Patrik Henningsson <
notifications@github.com> wrote:

Thanks very much @israels https://github.com/israels for looking into
this issue. Since the API of node-walkdir was compatible with node-findit
I've now done the switch and it seems to work just fine. Tested it in
Windows too, and it works much better now. I published v0.1.4 to NPM with
the fix. @EisenbergEffect https://github.com/EisenbergEffect may be
interested to give it a spin again now I suppose :)

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-12117538.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

Answer 12 · 2013-02-03T14:32:46.000Z

Running now gives me:

module.js:340
throw err;
^
Error: Cannot find module 'walkdir'
at Function.Module._resolveFilename (module.js:338:15)
at Function.Module._load (module.js:280:25)
at Module.require (module.js:362:17)
at require (module.js:378:17)
at Object. (C:\Users\EisenbergEffect\AppData\Roaming\npm\node_mod
ules\madge\lib\parse\base.js:10:11)
at Module._compile (module.js:449:26)
at Object.Module._extensions..js (module.js:467:10)
at Module.load (module.js:356:32)
at Function.Module._load (module.js:312:12)
at Module.require (module.js:362:17)

If I install the walkdir package manually, it seams to work.

Answer 13 · 2013-02-03T14:49:51.000Z

That seems very weird since package.json is up to date ..

Can you list the folders in C:\Users\EisenbergEffect\AppData\Roaming\npm\node_mod
ules\madge\node_modules?

Did you install walkdir globally or locally to fix the problem?

Answer 14 · 2013-02-03T18:43:32.000Z

Folder there are: coffee-script, colors, commander, commandir, detective,
findit, graphiz, resolve, uglify-js
I fixed the problem with a global install of walkdir.

On Sun, Feb 3, 2013 at 9:49 AM, Patrik Henningsson <notifications@github.com

wrote:

That seems very weird since package.json is up to date ..

Can you list the folders in
C:\Users\EisenbergEffect\AppData\Roaming\npm\node_mod
ules\madge\node_modules?

Did you install walkdir globally or locally to fix the problem?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-13047896.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

Answer 15 · 2013-02-03T18:53:32.000Z

Strange .. and you're installing madge with NPM? If so, can you copy the entire output when running "npm install madge" and include it here? If you're installing directly from the GitHub repository can you include the output when running "npm install" in the project folder?

Answer 16 · 2013-02-03T18:58:25.000Z

Here you go:

colors@0.6.0-1C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge\n
ode_modules\colors

commander@1.0.0C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge
node_modules\commander

detective@0.1.1C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge
node_modules\detective

resolve@0.2.3C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge\no
de_modules\resolve

walkdir@0.0.5C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge\no
de_modules\walkdir

coffee-script@1.3.3C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\ma
dge\node_modules\coffee-script

uglify-js@1.2.6C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge
node_modules\uglify-js

temp@0.4.0C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge\node_
modules\graphviz\node_modules\temp

graphviz@0.0.7C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge\n
ode_modules\graphviz

madge@0.1.4 C:\Users\EisenbergEffect\AppData\Roaming\npm\node_modules\madge

(Now I see walkdir...perhaps I just wasn't up to date before?)

On Sun, Feb 3, 2013 at 1:53 PM, Patrik Henningsson <notifications@github.com

wrote:

Strange .. and you're installing madge with NPM? Can you copy the entire
output when running "npm install madge" and include it here?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/8#issuecomment-13051619.

Rob Eisenberg,
Blue Spire Consulting, Inc.
Caliburn Project
850.264.3996

Answer 17 · 2013-02-03T19:01:06.000Z

Yea, seems correct. Don't know why you had problem before .. but glad it worked for you now :)