palantir/blueprint

Some tests failing when running `yarn verify`

Opened this issue · 3 comments

Environment

  • Package version(s): latest
  • Operating System: macOS Sonoma 14.5
  • Browser name and version: n/a

Steps to reproduce

Follow README.md setup steps up until yarn verify

Actual behavior

The following errors:
Screenshot 2024-07-25 at 1 41 40 PM
Screenshot 2024-07-25 at 1 41 24 PM

Expected behavior

the tests should not error locally but seemingly pass running in CI (TODO: confirm these tests actually are running in CI)

Possible solution

Wondering if all scroll related tests are related to running this on a macbook where the default is to hide scrollbars unless scrolling. I did try changing this operating system setting but saw the same failures (though perhaps a restart would be needed for the changes to take effect here, or I hit some test cache)

If https://github.com/palantir/blueprint/pull/6925/files merges make sure readme is re-updated if this is addressed

@evansjohnson I also encountered the error in cssVariables.test.ts (but not the scrollbar issues unfortunately). Decided to dig in a bit and was able to get the test to pass with #6934. This doesn't necessarily address the underlying issue, but it does make the devx a bit better for newcomers (like myself)

Reopening since #6934 doesn't address the whole issue (scroll test flake)