palantir/go-githubapp

404 page not found

Opened this issue · 2 comments

when creating a github app on github.com for the example and running:

go run ./example

web hook delivery fails with 404 page not found

Looks like this because of the line:

http.Handle(githubapp.DefaultWebhookRoute, handler)

which expects requests at /api/github/hook whereas my app on github.com was configured to post to /.

This makes it work:

http.Handle("/", handler)

Hey @tekumara,

As you noticed, this is expected based on the code. I think we need to update our docs to reflect that you should point the github app's webhook configuration to myapp.domain/api/github/hook.