palantir/go-githubapp

PR #212 has broken the example code

Closed this issue · 3 comments

PR #212 has broken the example code.

installationID := githubapp.GetInstallationIDFromEvent(&event)

cannot use &event (value of type *"github.com/google/go-github/v48/github".IssueCommentEvent) as githubapp.InstallationSource value in argument to githubapp.GetInstallationIDFromEvent: *"github.com/google/go-github/v48/github".IssueCommentEvent does not implement githubapp.InstallationSource (wrong type for method GetInstallation)
		have GetInstallation() *"github.com/google/go-github/v48/github".Installation
		want GetInstallation() *"github.com/google/go-github/v47/github".Installation

ctx, logger := githubapp.PreparePRContext(ctx, installationID, repo, event.GetIssue().GetNumber())

cannot use repo (variable of type *"github.com/google/go-github/v48/github".Repository) as *"github.com/google/go-github/v47/github".Repository value in argument to githubapp.PreparePRContext

Note, that be downgrading to 47 it fixes the code, but I am not sure if that is having an impact on how the example app is behaving, see #213. Currently it gets a webhook, but no further events happen.

Hey @lukehinds, thanks for the bug report.

Are you running the example main.go program directly, or are you modifying it or including it in your own program and using v47? I can take a look later today as well.

Hey @lukehinds, thanks for the bug report.

Are you running the example main.go program directly, or are you modifying it or including it in your own program and using v47? I can take a look later today as well.

That's a good point. I ran go mod init and then copied the files from example/ into my new folder (with the new go.mod). I then ran go mod tidy

I will take another look