Add .isolator_ignore support
viralpraxis opened this issue · 3 comments
The .isolator_todo.yml configuration file which is used to temporary ignore some parts of source code is a great feature, but its name might be misleading in case of code which intentionally contains some IO calls inside a transaction. IMO it'd be great if there was support for .isolator_ignore.yml or .isolatorignore.yml file with the same syntax as .isolator_todo.yml but different purpose. Current approach works perfectly with small development teams but if there are a lot of people working on making codebase sync with Isolator it might be a problem.
That's currently possible to implement a custom Ignorer class which respects both todo and ignore files but I think it'd be good to make it a built-in feature.
So, I'd like to suggest to add the configuration file which points to code that will not be fixed any time soon and keep .isolator_todo.yml as a TODO-list. Thanks for a great gem BTW.
Thanks for the proposal. Sounds reasonable.
We can call ignorer.prepare multiple times; so, supporting .isolator_ignore.yml could be as simple as adding one more line to
isolator/lib/isolator/railtie.rb
Line 18 in 2d421e5
Would you like to propose a PR?
Yep, I'll make a PR soon
PR is done :) @palkan