pallets-eco/cachelib

Breaking changes on 0.4.0

sumeshdubey-squla opened this issue · 2 comments

There is a type hinting on line 31 of redis.py for the host to be string and also if host is not string (in case of rediscluster) then in that case the self.__client is not available on line 51 of redis.py as the "else:" is removed. For everyone who are sending rediscluster client in host, this change will break their application

Environment:

  • Python version: 3.7
  • CacheLib version: 0.4.0

Hey @sumeshdubey-squla, thanks for taking the time to let us know about this. I'll look into the issue and probably release a fix as soon as I get home (currently at work)

@northernSage thanks a lot for the quick response and fixing this in no time