Plan for next release - v2.0

Question

Plan for next release - v2.0

Opened this issue 5 months ago · 32 comments

Answer 1 · 2024-07-17T10:22:01.000Z

Answer 2 · 2024-07-17T10:39:53.000Z

What makes you suggest 1.7?

I think standard practice would be to assume Semantic Versioning, which says breaking changes should be a major versioning bump (ie 1 to 2). Dropping python 3.7 and dropping flask-babelex are breaking changes, so I think V2 would be the logical step to me.

Happy to hear counter arguments though.

Answer 3 · 2024-07-17T12:34:08.000Z

Good then did not see any breaking changes from the description. Good 👍 for a 2.0.

Answer 4 · 2024-07-17T12:45:31.000Z

I believe #2407 is suitable for the next release.

Answer 5 · 2024-07-18T20:52:56.000Z

Flask-Babel and host_matching PRs are up. Will leave open for feedback for a few days.

Aiming to do a 2.0.0rc0 release next week ish.

Answer 6 · 2024-07-20T18:37:33.000Z

Right. We have a bunch of stuff merged - I'm thinking of doing a 2.0.0rc0 release, maybe tomorrow. That would mean (in my head) no more feature merges - only bug fix merges - until 2.0.0 proper is released.

Do we think we want to try to get anything else simple/quick in urgently before the rc0 release?

Answer 7 · 2024-07-23T19:32:41.000Z

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

Answer 8 · 2024-07-24T10:11:08.000Z

There are more configuration changes too, like when creating Admin instance, so I guess it is fair to think about the next release tagging with 2.0.0

Answer 9 · 2024-07-24T18:56:47.000Z

@cjmayo Have added SQLAlchemy 2/Flask 3/WTForms 3 as target changes for a 2.0.0 release, if you're happy with that? I'm happy to try to help where needed, although it looks like maybe you've got it covered.

I'm happy. I think I have enough - at least to get the tests to pass (I have been using these patches for a while with the new dependencies).

Answer 10 · 2024-07-24T19:00:32.000Z

Would you like to weigh in/mind weighing in on #2476? It deals with dependencies too, specifically making it more explicit what dependencies are required for certain features and what versions we support. It doesn't do much work bumping dependencies, but should make it easier to test+validate dep bumps in the future.

Answer 11 · 2024-07-30T21:15:38.000Z

Ok - the target date is obviously slipping a bit, but I think it's useful to get a few more of these things in before doing some kind of pre-release.

Notably:

Answer 12 · 2024-08-04T21:27:13.000Z

Can we have in the docs a suggested approach for considering client's timezone when submitting datetime fields? I am referring to #1892

Answer 13 · 2024-08-07T19:04:59.000Z

@ElLorans would you like to put up a PR adding some information and/or an example? I think specifically an example would be super helpful :)

Answer 14 · 2024-08-08T19:59:06.000Z

@samuelhwilliams just opened #2502

Answer 15 · 2024-08-11T16:19:19.000Z

Since the changes merged so far for v2.0.0 include a lot of dependency bumps, I think it also makes sense to switch the S3 admin interface over from using boto to boto3, and the azure-blob-storage interface to using azure-storage-blob>=12. So will try to include those as well.

Answer 16 · 2024-08-12T07:28:45.000Z

Thank you for all the hard work on the new release. I noticed that while there are many exciting updates mentioned, there hasn't been any discussion about the state of translations. There was an earlier issue (#1950) that raised concerns about updating translations, and I was wondering if this has been addressed in the latest release or if there are any plans to do so.

Answer 17 · 2024-08-12T08:18:48.000Z

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

Answer 18 · 2024-09-02T17:41:33.000Z

Going to publish v2.0.0a0 shortly - this is an pre-release so would be grateful to anyone able to test it out and see what bugs there may be 🙏

It's not feature-complete yet necessarily, and I still think it'd be nice to get updates to fileadmin for AWS and Azure in, but I just haven't had time yet. Anyone able to contribute those changes (essentially migrating fileadmin.s3 to use boto3, and updating fileadmin.azure to use azure-storage-blob>=12)

Answer 19 · 2024-09-03T16:51:41.000Z

v2.0.0a0 is now published

Answer 20 · 2024-09-06T20:30:53.000Z

Hey @pajusmar - it's a good question. I've asked it on the pallets-eco discord to work out what our plan is with translations... 👀

@samuelhwilliams, I saw on Discord that I should submit a pull request to modify translations.

I would really like to change one word. "Add" is a verb, not a noun, as it's currently translated into Estonian. The correct translation is "Lisa". Will it make it to 2.0, or are we past the string freeze?

Answer 21 · 2024-09-06T22:28:38.000Z

Nope, by all means put up a PR please. Changes now would still go into V2.0.0 :)

Answer 22 · 2024-09-23T07:06:10.000Z

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

Answer 23 · 2024-09-23T07:16:15.000Z

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

Yes that's annoying for sure

Answer 24 · 2024-10-11T21:31:13.000Z

Out of curiosity – is there any progress on #1974? (Or at least any information about its causes?)

It just seems kind of bizarre that "View record" & "Edit record" button tooltips are translated, but "Delete record" is not 😅

This is fixed in #2526 (comment) . @samuelhwilliams can we release 2.0? Are there still DeprecationWarnings?

Answer 25 · 2024-10-11T21:57:33.000Z

I will (try to) do a 2.0.0a1 soon. I think there's probably still more stuff that makes sense to do for a 'proper' v2 release - updating both of the fileadmin implementations for a start.

Answer 26 · 2024-10-26T18:16:40.000Z

I've done a v2.0.0a1 now that includes those changes and compatibility support for wtforms v3.2+

Answer 27 · 2024-10-26T18:17:47.000Z

I do still think it would be good to get in updates for s3/ABS before doing an official release of v2.0.0, but I also am aware that it's taking quite a chunk of time for me to have time for that and there's maybe not a huge amount of appetite from anyone else to add it. :(

Possibly also good to drop python 3.8 and add python 3.13, too.

Answer 28 · 2024-10-27T09:38:48.000Z

Ok I found time to do boto->boto3, so just azure blob storage to go really 🤞

Answer 29 · 2024-10-28T21:17:36.000Z

that's now available as v2.0.0a2

Answer 30 · 2024-11-12T20:09:18.000Z

@samuelhwilliams Is there an issue about azure blob storage? I can probably tackle that. Just wondering if there were known issues about upgrading, or just general SDK interface changes.

Answer 31 · 2024-11-12T20:33:46.000Z

I'm not aware of any issues specifically - but that is mostly because I haven't looked closely yet. It may well just be SDK interface changes. Would be very grateful if you wanted to tackle it, it's really the last big blocker for an official v2 release, I think 👀

If there isn't an obvious issue open, please feel free to open one to track it 🙏

Answer 32 · 2024-11-21T20:49:45.000Z

PR for Azure storage upgrade: https://github.com/pallets-eco/flask-admin/pull/2573/files

When the changeset is locked