pallets-eco/flask-social

Denied Twitter Connection fails upon return to Flask Social

Closed this issue · 1 comments

eriktaubeneck commented

If a user registers or logs in cold from Twitter, but hits "Cancel" on Twitter, the module fails gracefully. However if a user who is already logged in, by other means, clicks Connect to Twitter, but then hits "Cancel" on Twitter, the module raises an AttributeError with the following stack trace:

  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1836, in __call__
    return self.wsgi_app(environ, start_response)
  File "/Users/erik/Documents/workspace/flask-social-example/app/middleware.py", line 16, in __call__
    return self.app(environ, start_response)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1820, in wsgi_app
    response = self.make_response(self.handle_exception(e))
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1403, in handle_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask_social/views.py", line 153, in connect_callback
    return connect_handler(provider.authorized_handler(connect)(), provider)
  File "/Users/erik/Documents/workspace/flask-social-example/venv/lib/python2.7/site-packages/flask_social/views.py", line 120, in connect_handler
    cv.setdefault('user_id', current_user.get_id())
AttributeError: 'Response' object has no attribute 'setdefault'

The issue can be raised using Flask-Social-Example with my recent bug fixes.