pallets/jinja

Incorrect list comprehension

lindhe opened this issue · 2 comments

lindhe commented

This list comprehension is incorrect:

image

https://jinja.palletsprojects.com/en/latest/templates/#jinja-filters.selectattr

It says u for user in users when it should be user for user in users (I'm pretty sure). Tried to find it here in this repo, but was unable to. Didn't find a link to GitHub on the docs page, so hope this is the right place to post.

Cheers!

ThiefMaster commented

https://github.com/pallets/jinja/blob/3.1.x/src/jinja2/filters.py#L1632-L1633

PR welcome :) (against the 3.1.x branch)
Note that the rejectattr docstring has the same issue.

lindhe commented

Ah, there it is! Thank you. PR coming soon!