pambrose/prometheus-proxy

WebSockets Support

ScottGuymer opened this issue · 6 comments

While creating a POC of using the proxy I have run into a couple of platform issues with supporting gRPC. Have you considered WebSockets as additional transport mechanism?

Would you be open to having it added? How much effort do you think it would be to add?

The proxy uses a single, bidirectional, asynchronous connection. I have not used WebSockets, so I cannot say for sure how difficult it would be to swap it in.

I think that websockets and gRPC would fulfil the same role here and provide an alternative to the tcp connections needed by gRPC. You can use standard web proxies and security mechanisms.

I will take a look and see how much of a challenge it would be to add in as an option.

One thing to keep in mind: gRPC uses HTTP/2 under the covers.

Ah sorry yes. It's the lack of http/2 support in some platforms that is the issue.

Specifically for me in the cloud foundry based platform that I am using.

The TCP comment comes from me trying to do a direct TCP route to the proxy (and failing)

My feeling is that websockets support may be more widespread.

Making predictions is above my pay grade, but given Google's push on gRPC and its fast-growing usage, it seems reasonable to expect products to support HTTP/2 sooner rather than later.

Yeah I totally agree with you! Just hope my platform is not one of the laggards... 😁