astype tests failing for `f16`, `float128`, `c32` and `complex256` on MacOS arm64 platforms
Closed this issue · 2 comments
loicdiridollou commented
Describe the bug
MacOS arm64 (M1 and above) platforms do not recognize some dtypes from
FAILED tests/test_series.py::test_astype_float['f16'-<class 'numpy.longdouble'>] - TypeError: data type 'f16' not understood
FAILED tests/test_series.py::test_astype_float['float128'-<class 'numpy.longdouble'>] - TypeError: data type 'float128' not understood
FAILED tests/test_series.py::test_astype_complex['c32'-<class 'numpy.clongdouble'>] - TypeError: data type 'c32' not understood
FAILED tests/test_series.py::test_astype_complex['complex256'-<class 'numpy.clongdouble'>] - TypeError: data type 'complex256' not understood
To Reproduce
Run poetry run poe test_all on a Mac M1 or above (for reference I ran a build on GitHub Actions, see https://github.com/loicdiridollou/pandas-stubs/actions/runs/11981847576/job/33408829929)
Please complete the following information:
- OS: MacOS
- OS Version 15
- python version 3.10/3.11/3.12/3.13
- version of type checker NA
- version of installed
pandas-stubsNA
Dr-Irv commented
This is pretty straightforward to fix. The tests in tests/test_series.py for those 4 types should be skipped at runtime if platform.processor() is arm
Ideally, we'd also have a Github action that would do tests on Mac ARM so this (and anything else) would be caught there.
loicdiridollou commented
Okay great!
Just wanted to get the buy in for the fix, I will add the Mac-os 14 runner
to have the build run on arm64.
…On Mon, Nov 25, 2024 at 10:38 AM Irv Lustig ***@***.***> wrote:
This is pretty straightforward to fix. The tests in tests/test_series.py
for those 4 types should be skipped at runtime if platform.processor() is
arm
Ideally, we'd also have a Github action that would do tests on Mac ARM so
this (and anything else) would be caught there.
—
Reply to this email directly, view it on GitHub
<#1051 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AMQNSQBN3U4BXKCFHYJ6KKL2CM76JAVCNFSM6AAAAABSKMZ36CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIOJYGM2TKOJXGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>