pandoc/dockerfiles

Bad commits on master branch

daamien opened this issue · 3 comments

daamien commented

Hey guys,

I made a mistake this morning and pushed a file in .github/workflows/ while thinking I was in another personnal github repo.

I realized my error immediatly and reverted the commit. But now the commit history is kind of dirty:

https://github.com/pandoc/dockerfiles/commits/master

Those 2 last commits can be completely removed with git reset --hard HEAD~2 but then it would require a git push --force which I think is not allowed on the main branch. Maybe disabling the protection for a few seconds and reenabling it after the clean up ?

I'm really sorry about that. I have removed the master branch from my pandoc/dockerfiles repo so that I should never happen again....

alerque commented

The history is dirty, but no harm done. It isn't like you committed some huge binary to the repo or something. I think force-pushing would stand more chance of being disruptive because it's possible people have Docker pulls based on the HEAD checksum already. I would be inclined to just leave it and move on.

tarleb commented
daamien commented

Thanks for the kind answers.

I'm ok with keeping my mistakes in the git history :)