Feature: Polish loading states
Closed this issue · 8 comments
Important
If you would like to work on this, please comment and we will assign you to the issue.
Describe the bug
There are some async operations that are handled by a button but there is no loading/disabled state in design system for button right now so this could be handled.
To Reproduce
Steps to reproduce the behavior:
- Try to import account by typing ENS handle (but probably more places)
Expected behavior
When operation handled by a button is async it will show some spinner instead of text and disable the button.
Do you think this might be partially related to the huge amount of errors I get very soon after loading the test dapp?
Happy for someone to add a loading prop or something to the design system Button. We already have a spinner SVG you can reuse.
I think the whole UX for loading state could be improved:
- For button loading we can use spinner
- For UI loading we can come up with loading skeleton design
LMK what you think!
Yes, I agree that loading state can definitely be improved. It's pretty much non-existent.
Happy for those decisions, would you like to work on this?
I see that you started adding also other issues, maybe it would be great to tag them with a priority badge.
My OSS contribution time is limited because of work at @trezor (which is open source but you know...).
So just asking from what issue would Rivet benefit the most ATM?
Yes, I agree that loading state can definitely be improved. It's pretty much non-existent.
Happy for those decisions, would you like to work on this?
Would love to but I will be busy this week, if no one is assigned till this Sunday I can take it
I'd be down to take a look at this one!