paragonie/halite

MutableFile constructed with string assumes that file exists

Furgas opened this issue · 6 comments

Furgas commented

Is this desired behaviour that we should create the output file before calling ex. File::encrypt()? What's the reasoning?

beeare commented

Is this desired behaviour that we should create the output file before calling ex. File::encrypt()? What's the reasoning?

In older versions of halite it was not required, so it seems to be a change that should be reviewed - Is it really desired behaviour?

beeare commented

454d9df7baeddc1365e629537186ca1a0906e574 was the commit with that change in MutableFile class.

Furgas commented

Good to know. So, I guess, it should be answered by the commit author.

duronrulez commented

Any news on this? We are having similar issues after upgrading to latest version. Do we really need to have the output file created prior to passing it to encrypt?

I guess another option for us is to wrap the filename string var in fopen(), where it will automatically try to create the file if its missing

paragonie-scott commented

D'oh! WritableFile should be allowed to not exist before creation. This is a bug. I'll fix it ASAP.

paragonie-scott commented

This is fixed in v4.5.2. Thanks for reporting it.