consider refactor CliConfiguration in such way to reduce its footgun factor
Opened this issue · 1 comments
Right now it have many default implementations, well, too many. This means client can miss some implementations and still everything appears to be working, until I am trying to set the config and it doesn't work.
In my particular case, I did not implement those methods for the RelayChainCli
for Acala
polkadot-sdk/substrate/client/cli/src/config.rs
Lines 318 to 326 in ede4a36
and --rpc-max-request-size
and many more parameters doesn't work for the embed relaychain node in Acala.
Maybe there's should be an non-production-defaults feature that the defaults are created under. That way when you're ready for productionisation you take the feature off and have to make some explicit implementations.