parro-it/libui-node

Freeing the UiDrawPath

mimecorg opened this issue · 2 comments

mimecorg commented

Unlike most other drawing related classes, UiDrawPath has an explicit freePath() method, and the path handle is not freed automatically in the destructor. So when the UiDrawPath is destroyed by the garbage collector, the path handle is never freed. Is this intentional?

mischnic commented

Is this intentional?

I don't remember that it was. The other area classes were changed in this commit: 3f99317

@parro-it I commited the change to https://github.com/parro-it/libui-node/commits/path-destructor.
Should we keep the function as a noop for compatibility? It's missing in libui-napi.

parro-it commented

I also don't remember it to be intentionally done...

@parro-it I commited the change to https://github.com/parro-it/libui-node/commits/path-destructor.
Should we keep the function as a noop for compatibility? It's missing in libui-napi.

I remember we already discuss the matter on libui-napi repo, and we decided to remove them...
so I suppose we can remove them here too.