parthenon-hpc-lab/athenapk

Unify treatment of mean molecular mass and temperature

forrestglines opened this issue · 2 comments

As mentioned in #2 about src/cluster/agn_triggering.cpp, it would be best to unify treatment of He mass fraction, mean molecular mass, and computing temperature.

Tightly couple (if not duplicate of #22) and I'm definitely in favor of this.
We should probably make this happen once the cluster PR is merged as it should be fairly straightforward.

This update should also include an input parameter for the Coulomb logarithm (which, e.g., enters the calculation of the thermal conductivity) and more generally unify/check consistency of prefactor in EOS related quantities (there are likely factor unity differences at different places because of the implicit assumption about the plasma composition).